Skip to content

Add RenderBoxView and RBLayer integration #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kyle-Ye merged 13 commits into from
Jan 11, 2026
Merged

Add RenderBoxView and RBLayer integration #711

Kyle-Ye merged 13 commits into from
Jan 11, 2026

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 4, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 4, 2026

🤖 Augment PR Summary

Summary: This PR introduces RenderBox-backed drawing infrastructure and updates RenderBox integration points.

Changes:

  • Bumps RenderBox-related dependencies (DarwinPrivateFrameworks, OpenRenderBox) in Package.resolved.
  • Adds an experimental Swift compiler flag (-experimental-spi-only-imports) to support @_spiOnly imports.
  • Moves/renames platform display-list view definitions into Sources/OpenSwiftUI/Render/DisplayList (AppKitDisplayList.swift, UIKitDisplayList.swift) and centralizes PlatformGraphicsView/PlatformInheritedView aliases.
  • Adds RenderBoxView, a PlatformGraphicsView subclass whose backing layer is an RBLayer subclass and participates in RenderBox async rendering behavior.
  • Adds DisplayListViewDrawing.swift with CGDrawingView (CoreGraphics-backed) and a WIP RBDrawingView (RenderBox-backed) conforming to PlatformDrawable.
  • Updates core rendering API types to use ORB* types (e.g. ORBDisplayList, ORBColor) and fixes QuartzCore import gating.
  • Removes placeholder shim enums that are now expected to come from the RenderBox shims module.

Technical Notes: The new RenderBox path is partially stubbed (several methods still call _openSwiftUIUnimplementedFailure()) but wires up the layer/delegate scaffolding for future rasterization work.

🤖 Was this summary useful? React with 👍 or 👎

augmentcode[bot]
augmentcode bot reviewed Jan 4, 2026
View reviewed changes
Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.76471% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.73%. Comparing base (0d222b7) to head (7cfce6f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...UI/Render/DisplayList/DisplayListViewDrawing.swift 0.00% 93 Missing ⚠️
...OpenSwiftUI/Render/DisplayList/RenderBoxView.swift 0.00% 40 Missing ⚠️
.../OpenSwiftUICore/Render/RasterizationOptions.swift 0.00% 15 Missing ⚠️
...rces/OpenSwiftUICore/Render/PlatformDrawable.swift 0.00% 10 Missing ⚠️
...SwiftUI/Render/DisplayList/AppKitDisplayList.swift 30.00% 7 Missing ⚠️
...OpenSwiftUICore/Render/RendererConfiguration.swift 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #711       +/-   ##
===========================================
+ Coverage   14.29%   28.73%   +14.43%     
===========================================
  Files         563      589       +26     
  Lines       33189    35991     +2802     
===========================================
+ Hits         4744    10341     +5597     
+ Misses      28445    25650     -2795

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 7e32912 into main Jan 11, 2026
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/renderbox branch January 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@augmentcode augmentcode[bot] augmentcode[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kyle-Ye